virajjasani commented on code in PR #4391:
URL: https://github.com/apache/hbase/pull/4391#discussion_r866360992
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java:
##########
@@ -355,9 +354,9 @@ private void checkStagingDir() throws IOException {
if (!this.fs.mkdirs(p, HiddenDirPerms)) {
throw new IOException("Failed to create staging directory " +
p.toString());
}
- } else {
- this.fs.setPermission(p, HiddenDirPerms);
}
+ this.fs.setPermission(p, HiddenDirPerms);
Review Comment:
In this case, `staging` dir would have already been created with
`HiddenDirPerms` permission i.e. `this.fs.mkdirs(p, HiddenDirPerms)` should be
true for this statement to be executed. So, isn't this statement redundant? We
already created staging dir with HiddenDirPerms permission and now we are again
setting `HiddenDirPerms` to `staging` dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
