[
https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535901#comment-17535901
]
Duo Zhang commented on HBASE-27023:
-----------------------------------
I downloaded the PR for https://github.com/apache/hbase/pull/4312/files
Run
{code}
grep Copyright 4312.diff.txt | grep -v "The Apache Software Foundation"
{code}
The output is
{noformat}
- * Copyright 2008 Google Inc. All rights reserved.
- * Copyright 2008 Google Inc. All rights reserved.
- * Copyright 2008 Google Inc. All rights reserved.
- * Copyright 2016 Josh Elser
- * Copyright (c) 2014 Martin Kleppmann
- * Copyright (c) 2014 Martin Kleppmann
- * Copyright (c) 2014 Martin Kleppmann
- * Copyright (c) 2014 Martin Kleppmann
- * Copyright (c) 2014 Martin Kleppmann
- * Copyright (c) 2014 Martin Kleppmann
{noformat}
{code}
grep COPYRIGHT 4312.diff.txt | grep -v "The Apache Software Foundation"
{code}
The output is
{noformat}
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- expectedVisString[3] = "(\"secret\"&\"" + COPYRIGHT + "\\\"" + ACCENT +
"\\\\" + SECRET
+ expectedVisString[3] = "(\"secret\"&\"" + COPYRIGHT + "\\\"" + ACCENT +
"\\\\" + SECRET + "\\\""
public static final String COPYRIGHT = "\u00A9ABC";
- public static final String UNICODE_VIS_TAG = COPYRIGHT + "\"" + ACCENT +
"\\" + SECRET + "\""
+ COPYRIGHT + "\"" + ACCENT + "\\" + SECRET + "\"" + "\u0027&\\";
- SECRET + "|" + CellVisibility.quote(COPYRIGHT), "(" +
CellVisibility.quote(COPYRIGHT)
+ SECRET + "|" + CellVisibility.quote(COPYRIGHT), "(" +
CellVisibility.quote(COPYRIGHT) + "&"
- s.setAuthorizations(new Authorizations(SECRET, CONFIDENTIAL, PRIVATE,
COPYRIGHT, ACCENT,
+ new Authorizations(SECRET, CONFIDENTIAL, PRIVATE, COPYRIGHT, ACCENT,
UNICODE_VIS_TAG));
- String[] labels = { SECRET, TOPSECRET, CONFIDENTIAL, PUBLIC, PRIVATE,
COPYRIGHT, ACCENT,
+ String[] labels = { SECRET, TOPSECRET, CONFIDENTIAL, PUBLIC,
PRIVATE, COPYRIGHT, ACCENT,
public static final String COPYRIGHT = "\u00A9ABC";
- public static final String UNICODE_VIS_TAG = COPYRIGHT + "\"" + ACCENT +
"\\" + SECRET + "\""
+ COPYRIGHT + "\"" + ACCENT + "\\" + SECRET + "\"" + "\u0027&\\";
- "(\"secret\"&\"" + COPYRIGHT + "\\\"" + ACCENT + "\\\\" + SECRET +
"\\\"" + "\u0027&\\\\"
+ "(!\"topsecret\"&\"secret\")|(!\"topsecret\"&\"confidential\")",
"(\"secret\"&\"" + COPYRIGHT
+ // { SECRET, TOPSECRET, CONFIDENTIAL, PUBLIC, PRIVATE, COPYRIGHT,
ACCENT,
- // { SECRET, TOPSECRET, CONFIDENTIAL, PUBLIC, PRIVATE, COPYRIGHT,
ACCENT,
{noformat}
No new findings, 'THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
CONTRIBUTORS' and 'A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
COPYRIGHT' are from the BSD license.
{noformat}
- * The portion of this file denoted by 'Copied from
com.google.protobuf.CodedOutputStream'
- * is from Protocol Buffers v2.5.0 under the following license
- *
- * Copyright 2008 Google Inc. All rights reserved.
- * http://code.google.com/p/protobuf/
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
{noformat}
The 'AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER' is
from MIT
{noformat}
-/*
- * The MIT License (MIT)
- * Copyright (c) 2014 Martin Kleppmann
- *
- * Permission is hereby granted, free of charge, to any person obtaining a copy
- * of this software and associated documentation files (the "Software"), to
deal
- * in the Software without restriction, including without limitation the rights
- * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
- * copies of the Software, and to permit persons to whom the Software is
- * furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice shall be included in
- * all copies or substantial portions of the Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
- * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
- * THE SOFTWARE.
- */
{noformat}
Run
{code}
grep copyright 4312.diff.txt | grep -v ASF | grep -v "this work for additional
information regarding copyright ownership"
{code}
The output is
{noformat}
- <copyright-end-year>${build.year}</copyright-end-year>
+ <copyright-end-year>${build.year}</copyright-end-year>
- * * Redistributions of source code must retain the above copyright
- * copyright notice, this list of conditions and the following disclaimer
- * * Redistributions of source code must retain the above copyright
- * copyright notice, this list of conditions and the following disclaimer
- * * Redistributions of source code must retain the above copyright
- * copyright notice, this list of conditions and the following disclaimer
- <copyright-end-year>${build.year}</copyright-end-year>
+ <copyright-end-year>${build.year}</copyright-end-year>
- * The above copyright notice and this permission notice shall be included in
- * The above copyright notice and this permission notice shall be included in
- * The above copyright notice and this permission notice shall be included in
- * The above copyright notice and this permission notice shall be included in
- * The above copyright notice and this permission notice shall be included in
- * The above copyright notice and this permission notice shall be included in
- <copyright-end-year>${build.year}</copyright-end-year>
+ <copyright-end-year>${build.year}</copyright-end-year>
- <copyright-end-year>${build.year}</copyright-end-year>
+ <copyright-end-year>${build.year}</copyright-end-year>
<!-- make sure every file has the following copyright header.
optionally, Spotless can set copyright years by digging
{noformat}
Still no new findgings, the 'Redistributions of source code must retain the
above copyright' and 'copyright notice, this list of conditions and the
following disclaimer' are from BSD, the 'The above copyright notice and this
permission notice shall be included in' is from MIT.
So let's find out the files where we incorrectly removed the license from.
> Add protobuf to NOTICE file
> ---------------------------
>
> Key: HBASE-27023
> URL: https://issues.apache.org/jira/browse/HBASE-27023
> Project: HBase
> Issue Type: Task
> Reporter: Peter Somogyi
> Assignee: Peter Somogyi
> Priority: Major
>
> The spotless formatting removed the protobuf credit from the
> AbstractByteRange. It is currently not included in the NOTICE file.
> https://github.com/apache/hbase/commit/9c8c9e7fbf8005ea89fa9b13d6d063b9f0240443#diff-f5806f14849a23b9265b022f3f330b80d08bcc10fcf69d8ee2e1b0d5af266d52
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
