bitterfox commented on PR #4425: URL: https://github.com/apache/hbase/pull/4425#issuecomment-1125609642
Thank you for checking this. We need this change in both branches. - branch-2.4 uses hbase-thirdparty.version = 3.5.1 which contains jetty 9.4.41.v20210516 - https://github.com/apache/hbase-thirdparty/blob/c28a235236b9f63ec1d36431e5d1b6c8d4b66d90/pom.xml#L139 - SslContextFacotry is deprecated in jetty 9.4.41 already - https://github.com/eclipse/jetty.project/blob/98607f93c7833e7dc59489b13f3cb0a114fb9f4c/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java#L187-L222 - branch-2.5 and master uses hbase-thirdparty.version = 4.1.0 which contains jetty 9.4.44.v20210927 - https://github.com/apache/hbase-thirdparty/blob/c120582f161149e0c8a6b2ec134b5bf22d859a21/pom.xml#L141 - SslContextFactory is deprecated in jetty 9.4.44 as well as - https://github.com/eclipse/jetty.project/blob/8da83308eeca865e495e53ef315a249d63ba9332/jetty-util/src/main/java/org/eclipse/jetty/util/ssl/SslContextFactory.java#L193-L223 JFYI, the deprecation was released in jetty 9.4.16 and the breaking change that throws the exception is released in jetty 9.4.23, so branches using jetty 9.4.23+ are affected https://github.com/eclipse/jetty.project/commit/6fb243ff6c96714d997e71064c3e7b99d114d633 https://github.com/eclipse/jetty.project/commit/f4d387e0d616df5ffa33fbbe5c9ad3e0b842657a https://github.com/eclipse/jetty.project/commit/53073ca25704ebd49c7133226053418a5124900f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org