bbeaudreault commented on code in PR #4125:
URL: https://github.com/apache/hbase/pull/4125#discussion_r891179372
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##########
@@ -216,11 +224,16 @@ private void saslNegotiate(final Channel ch) {
failInit(ch, e);
return;
}
- ch.pipeline().addFirst(new SaslChallengeDecoder(), saslHandler);
+ if (conf.getBoolean(HBASE_NETTY_RPCSERVER_TLS_ENABLED, false)) {
Review Comment:
In terms of the config, my second question is how one would transition an
active cluster to having ssl enabled. Is there some way to allow a rolling
upgrade by configurably handling handshake failures either on the server and/or
client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
