[ 
https://issues.apache.org/jira/browse/HBASE-6236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396531#comment-13396531
 ] 

Aditya Kishore commented on HBASE-6236:
---------------------------------------

@[~zhi...@ebaysf.com]

Agree that it would be a clean to move the prefix to a constant.

However, we would still want to enforce 2 criteria on the backup folder 
name/location:

1. The folder must be immediate child of HBase base folder to ensure that 
fs.rename() works, and 
2. Prefix starts with a "." to ensure that it does not conflict with or 
presumed to be a table directory.

Instead of making it configurable, how about print a message at the end 
notifying the user the location of the backup folder?
                
> Offline meta repair fails if the HBase base mount point is on a different 
> cluster/volume than its parent in a ViewFS or similar FS
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-6236
>                 URL: https://issues.apache.org/jira/browse/HBASE-6236
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>            Reporter: Aditya Kishore
>            Assignee: Aditya Kishore
>         Attachments: HBASE-6236_0.94.patch, HBASE-6236_trunk.patch
>
>
> While building the .META. and -ROOT- from FS data alone (HBASE-4377), hbck 
> tries to move the existing .META. and -ROOT- directories to a backup folder.
> This backup folder is created at the same level as the base HBase folder 
> (e.g. /hbase-xxxxxx if the base HBase folder is '/hbase').
> In a federated HDFS like ViewFS and other similar FS implementations, it is 
> not possible to rename files/directories across namespace volumes (ViewFS 
> guide section 3.5) and as a result hbck crashes.
> A solution to this problem is to create the backup directory under the folder 
> where HBase base folder has been mounted. This ensures that source and 
> destination of rename operation are on the same namespace volume.
> Patch for 0.94 and trunk is attached for review. The patch modifies the 
> location of the backup directory from '/hbase-xxxxxxx' to 
> '/hbase/.hbcktmp-xxxxxxx'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to