clarax commented on PR #109: URL: https://github.com/apache/hbase-operator-tools/pull/109#issuecomment-1158192498
Yes, I preferred that implementation for cleaner code. But I moved away to make it commands specific options per feedback on user experience. I see your point and can move up the parsing logic to HBCK2 methods that calls fsck methods so FileSystemFsck/ReplicationFsck don't have to handle the options. What do you think? This will still be inline with implementation other commands. I see your effort to reduce replication of code for -f option and -I with parseCommandWithFixAndInputOptions but it does seem too hard-coded for adding or removing command options. For other commands with command options such as bypass and assigns, I set up the options per command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
