[ https://issues.apache.org/jira/browse/HBASE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399713#comment-13399713 ]
Zhihong Ted Yu edited comment on HBASE-5630 at 6/22/12 11:29 PM: ----------------------------------------------------------------- {code} + } + else { + return getMaster().synchronousBalanceSwitch(on); + } {code} There is no need for else. If 'else' were to be kept, it should stay on the previous line after right brace. For TestSplitTransactionOnCluster.java: {code} // Turn off balancer so it doesn't cut in and mess up our placements. - this.admin.balanceSwitch(false); + this.admin.setBalancerRunning(false, false); {code} I think the second parameter should be true. TestSplitTransactionOnCluster fails on Jenkins occassionally - I wonder if this could be the cause. Will attach new 0.94 patch soon. was (Author: zhi...@ebaysf.com): {code} + } + else { + return getMaster().synchronousBalanceSwitch(on); + } {code} There is no need for else. If else were to be kept, it should stay on the previous line after right brace. For TestSplitTransactionOnCluster.java: {code} // Turn off balancer so it doesn't cut in and mess up our placements. - this.admin.balanceSwitch(false); + this.admin.setBalancerRunning(false, false); {code} I think the second parameter should be true. TestSplitTransactionOnCluster fails on Jenkins occassionally - I wonder if this could be the cause. Will attach new 0.94 patch soon. > hbck should disable the balancer using synchronousBalanceSwitch. > ---------------------------------------------------------------- > > Key: HBASE-5630 > URL: https://issues.apache.org/jira/browse/HBASE-5630 > Project: HBase > Issue Type: Improvement > Components: hbck > Affects Versions: 0.94.0, 0.96.0 > Reporter: Jonathan Hsieh > Assignee: Gregory Chanan > Priority: Minor > Attachments: 5630-0.94-v3.txt, HBASE-5630-94-v2.patch, > HBASE-5630-94.patch, HBASE-5630-trunk-v2.patch, HBASE-5630.patch > > > hbck disable the balancer using admin.balanceSwith(bool) when it would be > preferable to use the newer synchronusBalanceSwitch method found in 0.94 and > trunk branches. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira