comnetwork commented on code in PR #4595: URL: https://github.com/apache/hbase/pull/4595#discussion_r914434283
########## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java: ########## @@ -619,4 +615,13 @@ static void updateStats(Optional<ServerStatisticTracker> optStats, metrics -> ResultStatsUtil.updateStats(metrics, serverName, regionName, regionLoadStats)); }); } + + public static AsyncConnection createAsyncConnection(Configuration conf) throws IOException { + return FutureUtils.get(ConnectionFactory.createAsyncConnection(conf)); + } Review Comment: @bbeaudreault , thank you for review. Ok,I think we could just use `ConnectionFactory.createAsyncConnection(conf).get() `in ReplicationSink, because seems there is no other code could benefit from this. I have updated the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org