[GitHub] [hbase] apurtell commented on a diff in pull request #4608: HBASE-27186 Report block cache size metrics separately for L1 and L2

Mon, 11 Jul 2022 17:47:50 -0700 


apurtell commented on code in PR #4608:
URL: https://github.com/apache/hbase/pull/4608#discussion_r918453416


##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java:
##########
@@ -316,6 +316,8 @@ public interface MetricsRegionServerSource extends 
BaseSource, JvmPauseMonitorSo
   String BLOCK_CACHE_FREE_DESC = "Size of the block cache that is not 
occupied.";
   String BLOCK_CACHE_COUNT = "blockCacheCount";
   String BLOCK_CACHE_COUNT_DESC = "Number of block in the block cache.";
+  String BLOCK_CACHE_DATA_BLOCK_COUNT = "blockCacheDataBlockCount";

Review Comment:
   Add a small doc patch to note this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to