bbeaudreault commented on code in PR #4638:
URL: https://github.com/apache/hbase/pull/4638#discussion_r929944933
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:
##########
@@ -760,6 +830,37 @@ private void printHistogram(Histogram histogram) {
output.printf(locale, " 99%% <= %2.2f%n",
snapshot.get99thPercentile());
output.printf(locale, " 99.9%% <= %2.2f%n",
snapshot.get999thPercentile());
output.printf(locale, " count = %d%n", histogram.getCount());
+
Review Comment:
The min/max change is handled above on lines 822/823. The below logic prints
the counts-by-range, i.e. the last 4 lines here:
```
Key length:
min = 43
max = 137
mean = 104.97
stddev = 25.93
median = 105.00
75% <= 137.00
95% <= 137.00
98% <= 137.00
99% <= 137.00
99.9% <= 137.00
count = 852277
0 <= 10
785 <= 50
404643 <= 100
446849 <= 500
```
I could add a comment here just to describe what's happening. It's similar
to how we handle range counts in JMX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
