[GitHub] [hbase] apurtell commented on a diff in pull request #4643: HBASE-27201 Clean up error-prone findings in hbase-backup

[GitBox]

apurtell commented on code in PR #4643:
URL: https://github.com/apache/hbase/pull/4643#discussion_r930417557


##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java:
##########
@@ -1720,7 +1726,8 @@ public String[] getListOfBackupIdsFromMergeOperation() 
throws IOException {
       if (val.length == 0) {
         return null;
       }
-      return new String(val).split(",");
+      List<String> result = Splitter.on(',').splitToList(new String(val, 
StandardCharsets.UTF_8));

Review Comment:
   Ok, seems fine to do it with streams



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org