apurtell commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930512250
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:
##########
@@ -1717,7 +1716,13 @@ public void mergeRegionsSync(final byte[] nameOfRegionA,
final byte[] nameOfRegi
@Override
public void mergeRegions(final byte[] nameOfRegionA, final byte[]
nameOfRegionB,
final boolean forcible) throws IOException {
- mergeRegionsAsync(nameOfRegionA, nameOfRegionB, forcible);
+ try {
Review Comment:
`mergeRegions` will return immediately without waiting for or surfacing any
exception from the operation. This seems wrong. We don't expect to wait for the
master to complete the merge but we would expect to surface an IOException from
the RPC. Yet, it is a semantic change over previously released versions. For
discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
