ndimiduk commented on code in PR #4691:
URL: https://github.com/apache/hbase/pull/4691#discussion_r953611489
##########
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java:
##########
@@ -154,6 +154,18 @@ public class HttpServer implements FilterContainer {
public static final String NO_CACHE_FILTER = "NoCacheFilter";
public static final String APP_DIR = "webapps";
+ public static final String METRIC_SERVLETS_CONF_KEY =
"hbase.http.metrics.servlets";
+ public static final String[] METRICS_SERVLETS_DEFAULT = { "jmx", "metrics",
"prometheus" };
+ private static final ImmutableMap<String,
+ ServletConfig> METRIC_SERVLETS = new ImmutableMap.Builder<String,
ServletConfig>()
+ .put("jmx",
+ new ServletConfig("jmx", "/jmx",
"org.apache.hadoop.hbase.http.jmx.JMXJsonServlet"))
+ .put("metrics",
+ new ServletConfig("metrics", "/metrics",
"org.apache.hadoop.metrics.MetricsServlet"))
+ .put("prometheus", new ServletConfig("prometheus", "/prometheus",
Review Comment:
We should have changed the title of the jira to match the actual endpoint
this feature uses. People will be confused that `/metrics` does not emit the
prometheus formatted output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
