[ https://issues.apache.org/jira/browse/HBASE-27321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584259#comment-17584259 ]
Wellington Chevreuil commented on HBASE-27321: ---------------------------------------------- {quote} So I prefer the latter approach, to disable multiple cleaners run at the same time. {quote} +1 for this approach. > The ReplicationLogCleaner is not thread safe but can be called from different > thread at the same time > ----------------------------------------------------------------------------------------------------- > > Key: HBASE-27321 > URL: https://issues.apache.org/jira/browse/HBASE-27321 > Project: HBase > Issue Type: Bug > Components: master, Replication > Reporter: Duo Zhang > Priority: Critical > > In preClean method we will update the class fields and then use them in the > getDeletableFiles method. This implies that we will have only one cleaner run > at the same time. > But actually, in MasterRpcServices.runCleanerChore, we will call execute the > HFileCleaner and LogCleaner directly, not in the cleanerChore thread. > This could cause data loss for replication, which is a very serious problem. -- This message was sent by Atlassian Jira (v8.20.10#820010)