bbeaudreault commented on code in PR #4724:
URL: https://github.com/apache/hbase/pull/4724#discussion_r954070605
##########
hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/tls/TestX509Util.java:
##########
@@ -142,6 +142,38 @@ public void cleanUp() {
Security.setProperty("com.sun.security.enableCRLDP",
Boolean.FALSE.toString());
}
+ @Test
+ public void testCreateSSLContextWithClientAuthDefault() throws Exception {
Review Comment:
I add tests for ClientAuth passthrough here, but it's not really possible
(as far as i can tell) to access the TrustManager of the underlying
SslContext/SSLEngine. So I can't easily add tests here for the TrustManager
hostname verification arg passthrough. So instead we have the comprehensive
end-to-end tests in TestMutualTlsClientSide/ServerSide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
