sunhelly commented on code in PR #4725:
URL: https://github.com/apache/hbase/pull/4725#discussion_r955709921
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java:
##########
@@ -382,15 +381,20 @@ protected void requestCompactionInternal(HRegion region,
HStore store, String wh
// pool; we will do selection there, and move to large pool if necessary.
pool = shortCompactions;
}
- pool.execute(
- new CompactionRunner(store, region, compaction, tracker,
completeTracker, pool, user));
+
+ // A simple implementation for under compaction marks.
+ // Since this method is always called in the synchronized methods, we do
not need to use the
+ // boolean result to make sure that exactly the one that added here will
be removed
+ // in the next steps.
+ underCompactionStores.add(getStoreNameForUnderCompaction(store));
Review Comment:
Yes, the compaction mark adding and removing operations are in different
threads, we can't avoid the latter removing thread excuting faster than the
former adding thread. Let the marks be added before the compaction runner tasks
be added to the thread pool can keep the correct order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
