[
https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404642#comment-13404642
]
Hadoop QA commented on HBASE-6296:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12534127/6296v1.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2305//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2305//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2305//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2305//console
This message is automatically generated.
> Refactor EventType to track its own ExecutorService type
> --------------------------------------------------------
>
> Key: HBASE-6296
> URL: https://issues.apache.org/jira/browse/HBASE-6296
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6296v1.txt, java_hbase-6296-v0.patch,
> java_hbase-6296-v0.patch
>
>
> Currently there is a massive switch statement in
> org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for
> each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is
> you add an new event type, you will also have to change the executorservice
> file, if for nothing but to add the executor type. Instead the EventType
> should just be able to keep track of which executor it should use.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
