bbeaudreault commented on code in PR #4786:
URL: https://github.com/apache/hbase/pull/4786#discussion_r982763838
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerImpl.java:
##########
@@ -63,15 +64,17 @@
private final RetryingCallerInterceptor interceptor;
private final RetryingCallerInterceptorContext context;
private final RetryingTimeTracker tracker;
+ private final MetricsConnection metrics;
public RpcRetryingCallerImpl(long pause, long pauseForServerOverloaded, int
retries,
Review Comment:
so this class is IA.Private, so we should be able to just change this
constructor if we want rather than overload it. Is there a legit usage of this
existing constructor you wanted to leave alone?
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java:
##########
@@ -33,17 +33,24 @@ public class RpcRetryingCallerFactory {
private final ConnectionConfiguration connectionConf;
private final RetryingCallerInterceptor interceptor;
private final int startLogErrorsCnt;
+ private final MetricsConnection metrics;
public RpcRetryingCallerFactory(Configuration conf) {
Review Comment:
this class is also IA.Private, so we can try not to add to the overloads
here at least. I thought it wasn't IA.Private, but now that I see it is we can
make a breaking change here if need be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
