chrajeshbabu commented on code in PR #4805:
URL: https://github.com/apache/hbase/pull/4805#discussion_r984750812
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -288,6 +292,8 @@ public BucketCache(String ioEngineName, long capacity, int
blockSize, int[] buck
this.singleFactor = conf.getFloat(SINGLE_FACTOR_CONFIG_NAME,
DEFAULT_SINGLE_FACTOR);
this.multiFactor = conf.getFloat(MULTI_FACTOR_CONFIG_NAME,
DEFAULT_MULTI_FACTOR);
this.memoryFactor = conf.getFloat(MEMORY_FACTOR_CONFIG_NAME,
DEFAULT_MEMORY_FACTOR);
+ this.queueAdditionWaitTime = conf.getLong(QUEUE_ADDITION_WAIT_TIME,
+ DEFAULT_QUEUE_ADDITION_WAIT_TIME);
Review Comment:
By default don't want to add wait time because memory based offheap will be
faster. So it can be completely depending up on the use case like if the file
based offheap used eg. cloud ephemeral storages then configuring wait time
would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
