[ 
https://issues.apache.org/jira/browse/HBASE-26421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613084#comment-17613084
 ] 

Huaxiang Sun edited comment on HBASE-26421 at 10/5/22 6:53 PM:
---------------------------------------------------------------

Forward comments from review board here for better background of this jira.
h3. *[Apache9|https://github.com/Apache9]* commented [on Nov 8, 
2021|https://github.com/apache/hbase/pull/3825#issuecomment-963696081]
|What is the advantage here to use HFileLink?|

 *[sunhelly|https://github.com/sunhelly]* commented [on Nov 8, 
2021|https://github.com/apache/hbase/pull/3825#issuecomment-963870288]
|Thanks, [@Apache9|https://github.com/Apache9] . The main advantage here is 
that the first compaction after split can be a minor compaction instead of old 
major compaction, because only reference files should be compacted before the 
next split. In HBASE-26422, I described the compaction after splitting using 
HFileLink.
It also makes move hfiles between regions of the same table possible. Then the 
compaction is light weight, since it need not to read and rewrite the referred 
files.|

 *[Apache9|https://github.com/Apache9]* commented [on Nov 9, 
2021|https://github.com/apache/hbase/pull/3825#issuecomment-964161491]
|OK, and we do not need to use HalfStoreFileReader to read the HFile right? 
Sound like a good general improvement. I think this could be done on master and 
other active branches, not only on a feature branch.
Will take a look at the PR soon.|


was (Author: huaxiangsun):
Forward comments from review board here for better background of this jira.

 
h3. *[Apache9|https://github.com/Apache9]* commented [on Nov 8, 
2021|https://github.com/apache/hbase/pull/3825#issuecomment-963696081]
|What is the advantage here to use HFileLink?|
 
[!https://avatars.githubusercontent.com/u/10123703?s=80&u=6be309b7250884321e34ad1fad94072c3ddea60f&v=4|width=40,height=40!|https://github.com/sunhelly]
 
ContributorAuthor
h3. *[sunhelly|https://github.com/sunhelly]* commented [on Nov 8, 
2021|https://github.com/apache/hbase/pull/3825#issuecomment-963870288]
|Thanks, [@Apache9|https://github.com/Apache9] . The main advantage here is 
that the first compaction after split can be a minor compaction instead of old 
major compaction, because only reference files should be compacted before the 
next split. In HBASE-26422, I described the compaction after splitting using 
HFileLink.
It also makes move hfiles between regions of the same table possible. Then the 
compaction is light weight, since it need not to read and rewrite the referred 
files.|
 
[!https://avatars.githubusercontent.com/u/4958168?s=80&u=fc28b222c03c02201d705b025a5293d6c471f7b3&v=4|width=40,height=40!|https://github.com/Apache9]
 
Contributor
h3. *[Apache9|https://github.com/Apache9]* commented [on Nov 9, 
2021|https://github.com/apache/hbase/pull/3825#issuecomment-964161491]
|OK, and we do not need to use HalfStoreFileReader to read the HFile right? 
Sound like a good general improvement. I think this could be done on master and 
other active branches, not only on a feature branch.
Will take a look at the PR soon.|

> Use HFileLink file to replace entire file‘s reference when splitting
> --------------------------------------------------------------------
>
>                 Key: HBASE-26421
>                 URL: https://issues.apache.org/jira/browse/HBASE-26421
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Xiaolin Ha
>            Assignee: Xiaolin Ha
>            Priority: Major
>             Fix For: 2.5.0, 3.0.0-alpha-2
>
>
> ++When splitting store files, if a file should be owned by only one child 
> region, then there will be an entire file's reference in the child region. We 
> can use HFileLink files, just like those in snapshot tables, to replace the 
> reference files that refer to entire files.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to