charlesconnell commented on code in PR #4888:
URL: https://github.com/apache/hbase/pull/4888#discussion_r1028425833
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorker.java:
##########
@@ -207,14 +214,34 @@ private List<NormalizationPlan> calculatePlans(final
TableName tableName) {
return Collections.emptyList();
}
- final List<NormalizationPlan> plans =
regionNormalizer.computePlansForTable(tblDesc);
+ List<NormalizationPlan> plans =
regionNormalizer.computePlansForTable(tblDesc);
+
+ plans = truncateForSize(plans);
+
if (CollectionUtils.isEmpty(plans)) {
LOG.debug("No normalization required for table {}.", tableName);
return Collections.emptyList();
}
return plans;
}
+ private List<NormalizationPlan> truncateForSize(List<NormalizationPlan>
plans) {
Review Comment:
Done
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorker.java:
##########
@@ -207,14 +214,34 @@ private List<NormalizationPlan> calculatePlans(final
TableName tableName) {
return Collections.emptyList();
}
- final List<NormalizationPlan> plans =
regionNormalizer.computePlansForTable(tblDesc);
+ List<NormalizationPlan> plans =
regionNormalizer.computePlansForTable(tblDesc);
+
+ plans = truncateForSize(plans);
+
if (CollectionUtils.isEmpty(plans)) {
LOG.debug("No normalization required for table {}.", tableName);
return Collections.emptyList();
}
return plans;
}
+ private List<NormalizationPlan> truncateForSize(List<NormalizationPlan>
plans) {
Review Comment:
Done, and the break still works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
