[
https://issues.apache.org/jira/browse/HBASE-27542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650881#comment-17650881
]
Bryan Beaudreault commented on HBASE-27542:
-------------------------------------------
Does this actually cause a problem? I can't find evidence about why it was
added. You might be right that it's not necessary, but I'm also trying to think
about edge cases it may help with. One I can think of is if the DistCp process
ends un-gracefully, so the shutdown hook doesn't execute.
I'm wondering if this is causing a problem for you, maybe we can instead fix
whatever the bug is.
> Remove unneeded distcp log cleanup after incremental backups
> ------------------------------------------------------------
>
> Key: HBASE-27542
> URL: https://issues.apache.org/jira/browse/HBASE-27542
> Project: HBase
> Issue Type: Improvement
> Components: backup&restore
> Affects Versions: 3.0.0-alpha-3
> Reporter: Jarryd Lee
> Priority: Minor
>
> During the completion step of incremental backups, the
> [TableBackupClient|https://github.com/apache/hbase/blob/2c3abae18aa35e2693b64b143316817d4569d0c3/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java#L343-L355]
> ensures distcp logs are cleaned up. However,
> [DistCp|https://github.com/apache/hadoop/blob/b87c0ea7ebde3edc312dcc8938809610a914df7f/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java#L465-L476]
> already ensures that the metafolder, where the distcp logs are stored, is
> cleaned up via a [shutdown
> hook|https://github.com/apache/hadoop/blob/b87c0ea7ebde3edc312dcc8938809610a914df7f/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java#L439-L442].
> The TableBackupClient cleanup method should be able to be safely removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
