bbeaudreault commented on code in PR #4967:
URL: https://github.com/apache/hbase/pull/4967#discussion_r1082802553


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -3398,7 +3398,6 @@ private void scan(HBaseRpcController controller, 
ScanRequest request, RegionScan
             }
             boolean mayHaveMoreCellsInRow = 
scannerContext.mayHaveMoreCellsInRow();
             Result r = Result.create(values, null, stale, 
mayHaveMoreCellsInRow);
-            lastBlock.setValue(addSize(rpcCall, r, lastBlock.getValue()));

Review Comment:
   I removed `lastBlock` from this method, but we still need it in the caller. 
I explain the reasonings in my response to your other comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to