Apache9 commented on code in PR #4967:
URL: https://github.com/apache/hbase/pull/4967#discussion_r1089955244
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##########
@@ -336,6 +337,9 @@ protected static class HFileScannerImpl implements
HFileScanner {
// RegionScannerImpl#handleException). Call the releaseIfNotCurBlock() to
release the
// unreferenced block please.
protected HFileBlock curBlock;
+ // Whether we returned a result for curBlock's size in
getCurrentBlockSizeOnce().
Review Comment:
getCurrentBlockSizeOnce() -> recordBlockSize()
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -3431,8 +3441,10 @@ private void scan(HBaseRpcController controller,
ScanRequest request, RegionScan
// there are more values to be read server side. If there aren't
more values,
// marking it as a heartbeat is wasteful because the client will
need to issue
// another ScanRequest only to realize that they already have all
the values
- if (moreRows && timeLimitReached) {
- // Heartbeat messages occur when the time limit has been reached.
+ if (moreRows && (timeLimitReached || (sizeLimitReached &&
results.isEmpty()))) {
Review Comment:
Why sizeLimitReached needs an extra results.isEmpty check?
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -3343,7 +3341,20 @@ private void scan(HBaseRpcController controller,
ScanRequest request, RegionScan
ScannerContext.Builder contextBuilder =
ScannerContext.newBuilder(true);
// maxResultSize - either we can reach this much size for all
cells(being read) data or sum
// of heap size occupied by cells(being read). Cell data means its key
and value parts.
- contextBuilder.setSizeLimit(sizeScope, maxResultSize, maxResultSize);
+ // maxQuotaResultSize - max results just from server side
configuration and quotas, without
+
Review Comment:
Why an empty line here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
