sunhelly commented on code in PR #4536: URL: https://github.com/apache/hbase/pull/4536#discussion_r1125793291
########## hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java: ########## @@ -326,6 +326,11 @@ public enum OperationStatusCode { public static final String COMPACTION_KV_MAX = "hbase.hstore.compaction.kv.max"; public static final int COMPACTION_KV_MAX_DEFAULT = 10; + /** Parameter name for the scanner size limit to be used in compactions */ + public static final String COMPACTION_SCANNER_SIZE_MAX = + "hbase.hstore.compaction.scanner.size.limit"; + public static final long COMPACTION_SCANNER_SIZE_MAX_DEFAULT = 10 * 1024 * 1024L; // 10MB Review Comment: Thanks. I use 10MB for compaction because I think the region should be closed as soon as possible and avoid being blocked by compaction as much as possible, while there might some throttling strategies to limit the speed of compaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org