thangTang commented on code in PR #5107:
URL: https://github.com/apache/hbase/pull/5107#discussion_r1138355039
##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionAggregateSourceImpl.java:
##########
@@ -99,7 +98,6 @@ public void getMetrics(MetricsCollector collector, boolean
all) {
((MetricsRegionSourceImpl) regionMetricSource).snapshot(mrb, all);
}
}
- mrb.addGauge(Interns.info(NUM_REGIONS, NUMBER_OF_REGIONS_DESC),
regionSources.size());
Review Comment:
> Have you checked when we add this metrics? What is it used for?
Yes. This metric was introduced in
[HBASE-14166](https://issues.apache.org/jira/browse/HBASE-14166).
This ticket aims to solve the problem that some region metrics cannot be
displayed, but I didn't find any description about this metric.
My guess is that the author hoped to use it to judge whether the number of
region metrics met expectations.
Any way, I think our code does not depend on it internally, and it is more
appropriate for users to use the `regionCount` of the RS dimension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
