[ 
https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408521#comment-13408521
 ] 

Zhihong Ted Yu commented on HBASE-6338:
---------------------------------------

{code}
+    private Method getMethod(Class<? extends VersionedProtocol> protocol,
+        String methodName, Class[] parameterClasses) throws Exception {
{code}
javadoc for the above method would be desirable.

Please run test suite for the branches and publish result here.

Thanks
                
> Cache Method in rpc handler
> ---------------------------
>
>                 Key: HBASE-6338
>                 URL: https://issues.apache.org/jira/browse/HBASE-6338
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>         Attachments: HBASE-6338-90.patch, HBASE-6338-92.patch, 
> HBASE-6338-94.patch, HBASE-6338-trunk.patch
>
>
> Every call in rpc handler a Method will be created, if we cache the method 
> will improve a little.
> I test with 0.90, Average Class.getMethod(String name, Class... 
> parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to