[ https://issues.apache.org/jira/browse/HBASE-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408745#comment-13408745 ]
Zhihong Ted Yu commented on HBASE-6352: --------------------------------------- {code} + * @param source the byte array do duplicate + */ {code} Please add @return for the return value. {code} + System.arraycopy(source, source.length, result, 0, source.length); + return tail (source, source.length); {code} Indentation for return statement is off. Since this JIRA is marked as improvement, a patch for trunk should be generated. Thanks > Add copy method in Bytes > ------------------------ > > Key: HBASE-6352 > URL: https://issues.apache.org/jira/browse/HBASE-6352 > Project: HBase > Issue Type: Improvement > Components: util > Affects Versions: 0.94.0 > Reporter: Jean-Marc Spaggiari > Priority: Minor > Labels: Bytes, Util > Attachments: HBASE_JIRA_6352.patch, HBASE_JIRA_6352_v2.patch, > HBASE_JIRA_6352_v3.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > Having a "copy" method into Bytes might be nice to reduce client code size > and improve readability. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira