Apache9 commented on code in PR #5158:
URL: https://github.com/apache/hbase/pull/5158#discussion_r1159573079
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryBatch.java:
##########
@@ -52,6 +52,9 @@ class WALEntryBatch {
private Map<String, Long> lastSeqIds = new HashMap<>();
// indicate that this is the end of the current file
private boolean endOfFile;
+ // indicate the buffer size used, which is added to
+ // ReplicationSourceWALReader.totalBufferUsed
+ private long usedBufferSize;
Review Comment:
Since we have recorded the size here, I think we could use it directly in
many places(especially in ReplicationSourceShipper), so we do not need to
calculate the size of the WALEntryBatch again?
Anyway, can be a follow on issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
