Apache9 commented on code in PR #5241:
URL: https://github.com/apache/hbase/pull/5241#discussion_r1196702748
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java:
##########
@@ -124,7 +124,7 @@ public enum HasNext {
* You can call {@link #peek()} or {@link #next()} to get the actual {@link
Entry} if this method
* returns {@link HasNext#YES}.
*/
- public HasNext hasNext() {
+ public HasNext hasNext() throws IOException {
Review Comment:
The design here is to not throwing any exceptions, instead, always use the
return value to tell upper layers what to do...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
