sunhelly commented on code in PR #5259:
URL: https://github.com/apache/hbase/pull/5259#discussion_r1221284897
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java:
##########
@@ -76,7 +76,9 @@ public RWQueueRpcExecutor(final String name, final int
handlerCount, final int m
numWriteQueues = calcNumWriters(this.numCallQueues, callqReadShare);
writeHandlersCount = Math.max(numWriteQueues, calcNumWriters(handlerCount,
callqReadShare));
- int readQueues = calcNumReaders(this.numCallQueues, callqReadShare);
+ int readQueues = callqReadShare > 0 ?
Review Comment:
Thanks. I think when callqReadShare is 0, the RpcExecutor will be
`FastPathBalancedQueueRpcExecutor` by default (see SimpleRpcScheduler line 88),
not based on RWQueueRpcExecutor(which by default will create
`FastPathRWQueueRpcExecutor`), and then there are not distinguished queues, all
queues serve for read and write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
