hgromer commented on code in PR #5051:
URL: https://github.com/apache/hbase/pull/5051#discussion_r1276735457
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java:
##########
@@ -329,6 +343,17 @@ protected void cleanup(Context context) {
LOG.error("fail to close replicated connection in cleanup", e);
}
}
+ if (reCompareExecutor != null && !reCompareExecutor.isShutdown()) {
Review Comment:
so maybe something like this
```java
int activelyExecutingTasks = reCompareExecutor.getActiveCount();
context.getCounter(Counters.FAILED_RECOMPARE).increment(activelyExecutingTasks);
context.getCounter(Counters.BADROWS).increment(activelyExecutingTasks);
```
although this doesn't let us increment the original counter, unfortunately.
To do that I think we might need to manually track any active runnables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
