[GitHub] [hbase] Reidddddd commented on a diff in pull request #5323: HBASE-27966 HBase Master/RS JVM metrics populated incorrectly

[via GitHub]

Reidddddd commented on code in PR #5323:
URL: https://github.com/apache/hbase/pull/5323#discussion_r1281485254


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java:
##########
@@ -24,10 +24,12 @@
 @InterfaceAudience.Private
 public class MetricsIO {
 
+  private static volatile MetricsIO instance;
   private final MetricsIOSource source;
   private final MetricsIOWrapper wrapper;
 
-  public MetricsIO(MetricsIOWrapper wrapper) {
+  // visible for testing only

Review Comment:
   could use the annotation `@VisibleForTesting`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org