[GitHub] [hbase] NihalJain commented on a diff in pull request #5323: HBASE-27966 HBase Master/RS JVM metrics populated incorrectly

[via GitHub]

NihalJain commented on code in PR #5323:
URL: https://github.com/apache/hbase/pull/5323#discussion_r1281507076


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java:
##########
@@ -24,10 +24,12 @@
 @InterfaceAudience.Private
 public class MetricsIO {
 
+  private static volatile MetricsIO instance;
   private final MetricsIOSource source;
   private final MetricsIOWrapper wrapper;
 
-  public MetricsIO(MetricsIOWrapper wrapper) {
+  // visible for testing only

Review Comment:
   I initially thought to add same but checked code and found this is banned 
now. See 
https://github.com/apache/hbase/blob/f6c5dbe97832d4c7d301bce48792365dd2b79e8a/pom.xml#L2535
   
   So added a comment "visible for testing only" as done at other places in 
code base. See 
https://github.com/search?q=repo%3Aapache%2Fhbase+%22visible+for+testing%22&type=code
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org