[
https://issues.apache.org/jira/browse/HBASE-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412519#comment-13412519
]
Andrew Purtell edited comment on HBASE-6377 at 7/12/12 5:10 AM:
----------------------------------------------------------------
Perhaps not a full revert, but the "put" and "delete" metrics are not useful in
a basic LoadTestTool test scenario, so consider dropping those. The distinction
is increasingly only valid client side. Perhaps also remove the "get" one as
well so we're not in effect special casing a metric only into HRI.get().
Edit: But even after the above, the histograms remain for FS level ops, so
there's benefit to a partial revert only.
was (Author: apurtell):
Perhaps not a full revert, but the "put" and "delete" metrics are not
useful in a basic LoadTestTool test scenario, so consider dropping those. The
distinction is increasingly only valid client side. Perhaps also remove the
"get" one as well so we're not in effect special casing a metric only into
HRI.get().
> HBASE-5533 metrics miss all operations submitted via MultiAction
> ----------------------------------------------------------------
>
> Key: HBASE-6377
> URL: https://issues.apache.org/jira/browse/HBASE-6377
> Project: HBase
> Issue Type: Bug
> Components: metrics, regionserver
> Affects Versions: 0.96.0, 0.94.1
> Reporter: Andrew Purtell
>
> A client application (LoadTestTool) calls put() on HTables. Internally to the
> HBase client those puts are batched into MultiActions. The total number of
> put operations shown in the RegionServer's put metrics histogram never
> increases from 0 even though millions of such operations are made. Needless
> to say the latency for those operations are not measured either. The value of
> HBASE-5533 metrics are suspect given the client will batch put and delete ops
> like this.
> I had a fix in progress but HBASE-6284 messed it up. Before, MultiAction
> processing in HRegionServer would distingush between puts and deletes and
> dispatch them separately. It was easy to account for the time for them. Now
> both puts and deletes are submitted in batch together as mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
