virajjasani commented on code in PR #5369:
URL: https://github.com/apache/hbase/pull/5369#discussion_r1304704327
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotDescriptionUtils.java:
##########
@@ -432,6 +430,40 @@ public static void completeSnapshot(Path snapshotDir, Path
workingDir, FileSyste
}
}
+ static boolean shouldSkipRenameSnapshotDirectories(URI workingURI, URI
rootURI) {
+ // check scheme, e.g. file, hdfs
+ if (
+ workingURI.getScheme() == null
+ && (rootURI.getScheme() != null &&
!rootURI.getScheme().equalsIgnoreCase("file"))
Review Comment:
with "file", we could have ignored local fs, but you are right that we don't
need such explicit check, let me make this change, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
