[ 
https://issues.apache.org/jira/browse/HBASE-28059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762268#comment-17762268
 ] 

Hudson commented on HBASE-28059:
--------------------------------

Results for branch branch-2
        [build #875 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/875/]: 
(x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/875/General_20Nightly_20Build_20Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/875/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/875/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/875/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Use correct units in RegionLoad#getStoreUncompressedSizeMB()
> ------------------------------------------------------------
>
>                 Key: HBASE-28059
>                 URL: https://issues.apache.org/jira/browse/HBASE-28059
>             Project: HBase
>          Issue Type: Improvement
>          Components: Admin
>    Affects Versions: 2.5.5
>            Reporter: Charles Connell
>            Assignee: Charles Connell
>            Priority: Major
>             Fix For: 2.6.0, 2.4.18, 2.5.6
>
>
> When I run a snippet of code like this:
> {code:java}
> Map<byte[], RegionLoad> regionLoadMap = admin
>   .getClusterStatus()
>   .getLoad(
>     ServerName.parseServerName(
>       "my-server.my-company.net,60020,1693513660506"
>     )
>   )
>   .getRegionsLoad();
> for (byte[] startKey : regionLoadMap.keySet()) {
>   RegionLoad regionLoad = regionLoadMap.get(startKey);
>   LOG.info("Region {}: {}", Bytes.toStringBinary(startKey), regionLoad);
> } {code}
> I get logs like this:
> {noformat}
> Region <redacted-table-name>,<redacted row 
> key>,1659484033280.2b89407a1223720344bed425bf3c29b0.: numberOfStores=1, 
> numberOfStorefiles=3, storeRefCount=0, storefileUncompressedSizeMB=17998848, 
> lastMajorCompactionTimestamp=1693211464712, storefileSizeMB=5895, 
> compressionRatio=0.0003, memstoreSizeMB=1, readRequestsCount=118899553, 
> writeRequestsCount=731192, rootIndexSizeKB=9, totalStaticIndexSizeKB=10413, 
> totalStaticBloomSizeKB=6592, totalCompactingKVs=0, currentCompactedKVs=0, 
> compactionProgressPct=NaN, completeSequenceId=78093096, 
> dataLocality=1.0{noformat}
> The {{storefileUncompressedSizeMB}} is vastly larger than the 
> {{{}storefileSizeMB{}}}, so much more that it's not believable. I checked the 
> store files in question in this instance. Adding up the uncompressed size 
> reported in the HFile trailers sums to 5895 MiB, exactly 1024 times less than 
> the reported 17998848.
> The reason for the misreporting is that 
> {{RegionLoad#getStoreUncompressedSizeMB()}} converts the value from a 
> {{Size}} object wrong.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to