[GitHub] [hbase] bbeaudreault commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

[via GitHub]

bbeaudreault commented on code in PR #5228:
URL: https://github.com/apache/hbase/pull/5228#discussion_r1321620558


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java:
##########
@@ -692,6 +711,13 @@ public void updateRpc(MethodDescriptor method, Message 
param, CallStats stats, T
     // this implementation is tied directly to protobuf implementation 
details. would be better
     // if we could dispatch based on something static, ie, request Message 
type.
     if (method.getService() == ClientService.getDescriptor()) {
+      if (
+        "Get".equals(method.getName()) || "Mutate".equals(method.getName())
+          || "Scan".equals(method.getName()) || 
"Multi".equals(method.getName())
+      ) {
+        updateTableMetric(methodName.toString(), tableName, stats, e);

Review Comment:
   do we still need this, or can we simply add the call to `updateTableMetric` 
in the appropriate switch state cases below? Just to avoid unnecessary 
complexity and equality checks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org