bbeaudreault commented on code in PR #5384:
URL: https://github.com/apache/hbase/pull/5384#discussion_r1323167385
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##########
@@ -1700,6 +1721,21 @@ protected HFileBlock
readBlockDataInternal(FSDataInputStream is, long offset,
}
onDiskSizeWithHeader = getOnDiskSizeWithHeader(headerBuf,
checksumSupport);
}
+
+ // The common case is that onDiskSizeWithHeader was produced by a read
without checksum
+ // validation, so give it a sanity check before trying to use it.
+ //
+ // TODO: Should we also check the value vs. some multiple of
fileContext.getBlocksize() ?
Review Comment:
Do you want to do an interim imperfect check here, or just punt the whole
thing to 28077?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
