[ 
https://issues.apache.org/jira/browse/HBASE-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413195#comment-13413195
 ] 

Hadoop QA commented on HBASE-6384:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12536271/6384-trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than 
the trunk's current 4 warnings).

    -1 findbugs.  The patch appears to introduce 8 new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2370//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2370//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2370//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2370//console

This message is automatically generated.
                
> hbck should group together those sidelined regions need to be bulk loaded 
> later
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-6384
>                 URL: https://issues.apache.org/jira/browse/HBASE-6384
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.90.7, 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: 6384-trunk.patch
>
>
> Currently, hbck sidelines some regions to break big overlap groups to avoid 
> possible compaction and region split.  These sidelined regions should be
> bulk loaded back later.  Information about these regions is in the output.
> It will be much easier to group them together under the same sideline rootdir,
> for example, /hbase/.hbck/to_be_loaded/.  If so, even we lose the output
> file, we still know what regions to load back.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to