[ 
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413356#comment-13413356
 ] 

Zhihong Ted Yu commented on HBASE-4050:
---------------------------------------

{code}
+public interface BaseMetricsSource {
{code}
I suggest adding the following for above interface:
{code}
@InterfaceAudience.Public
@InterfaceStability.Evolving
{code}
{code}
+   * Subtract some amount to a gauge.
{code}
'to a' -> 'from a'
{code}
+        rms = 
ServiceLoader.load(ReplicationMetricsSource.class).iterator().next();
{code}
Shall we traverse the iterator and warn user if there are more than one 
implementation found ?

Will continue on the review board.
                
> Update HBase metrics framework to metrics2 framework
> ----------------------------------------------------
>
>                 Key: HBASE-4050
>                 URL: https://issues.apache.org/jira/browse/HBASE-4050
>             Project: HBase
>          Issue Type: New Feature
>          Components: metrics
>    Affects Versions: 0.90.4
>         Environment: Java 6
>            Reporter: Eric Yang
>            Assignee: Alex Baranau
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 4050-metrics-v2.patch, 4050-metrics-v3.patch, 
> HBASE-4050-0.patch, HBASE-4050-1.patch, HBASE-4050-2.patch, 
> HBASE-4050-3.patch, HBASE-4050-5.patch, HBASE-4050.patch
>
>
> Metrics Framework has been marked deprecated in Hadoop 0.20.203+ and 0.22+, 
> and it might get removed in future Hadoop release.  Hence, HBase needs to 
> revise the dependency of MetricsContext to use Metrics2 framework.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to