bbeaudreault commented on code in PR #2924: URL: https://github.com/apache/hbase/pull/2924#discussion_r1349678587
########## hbase-shell/src/main/ruby/hbase/admin.rb: ########## @@ -786,6 +787,12 @@ def alter(table_name_str, wait = true, *args) # There are 3 possible options. # 1) Column family spec. Distinguished by having a NAME and no METHOD. method = arg.delete(METHOD) + + if !method.nil? && method == 'avoid_reopening_regions' Review Comment: Can we just make a new argument `REOPEN_REGIONS => 'false'` The problem I have with using METHOD is it's not clear that you can use this with other "methods" like table_unset_conf. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org