jbewing commented on PR #5373: URL: https://github.com/apache/hbase/pull/5373#issuecomment-1768531160
I broke some tests in TestHStoreFile with https://github.com/apache/hbase/pull/5373/commits/e72afde5f41befcb132a1264f41f5287ccbb1629 due to some mocked HFile.Reader instances not having the `getDataBlockEncoding` method mocked as well. Instead of fixing those mocks, I'm going to keep the StoreFileScanner constructor simple (i.e. just `boolean` flags) and move the flag setting for to the primary `StoreFileReader#getStoreFileScanner` path. Let me know if you'd rather have me fix up the TestHStoreFile tests instead or even go with a different route. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
