judilsteve commented on code in PR #5501:
URL: https://github.com/apache/hbase/pull/5501#discussion_r1380962441


##########
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RowSpec.java:
##########
@@ -55,6 +59,19 @@ public RowSpec(String path) throws IllegalArgumentException {
     i = parseColumns(path, i);
     i = parseTimestamp(path, i);
     i = parseQueryParams(path, i);
+
+    if(keyEncoding == "b64") {
+      Base64.Decoder decoder = Base64.getDecoder();

Review Comment:
   Currently throwing when we call any of the endpoints in the checklist:
   
   ```
   javax.servlet.ServletException: 
org.apache.hbase.thirdparty.org.glassfish.jersey.server.ContainerException: 
java.lang.Error: Unresolved compilation problems:
           Base64 cannot be resolved to a type
           Base64 cannot be resolved
           Type mismatch: cannot convert from byte[] to boolean
   ```



##########
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RowSpec.java:
##########
@@ -55,6 +59,19 @@ public RowSpec(String path) throws IllegalArgumentException {
     i = parseColumns(path, i);
     i = parseTimestamp(path, i);
     i = parseQueryParams(path, i);
+
+    if(keyEncoding == "b64") {
+      Base64.Decoder decoder = Base64.getDecoder();

Review Comment:
   Currently throwing when I call any of the endpoints in the checklist:
   
   ```
   javax.servlet.ServletException: 
org.apache.hbase.thirdparty.org.glassfish.jersey.server.ContainerException: 
java.lang.Error: Unresolved compilation problems:
           Base64 cannot be resolved to a type
           Base64 cannot be resolved
           Type mismatch: cannot convert from byte[] to boolean
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to