chaijunjie0101 commented on code in PR #5494:
URL: https://github.com/apache/hbase/pull/5494#discussion_r1381679034
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/util/PrettyPrinter.java:
##########
@@ -184,7 +184,12 @@ private static long humanReadableIntervalToSec(final
String humanReadableInterva
hours = matcher.group(6);
minutes = matcher.group(8);
seconds = matcher.group(10);
+ } else {
+ LOG.warn(
+ "Given interval value : {} is not a number and not match human
readable format, TTL will set to 0.",
Review Comment:
Thanks for reviwing...
this method just used to convert TTL, it is a private method and just return
ttl...although it's name means not just for TTL...
maybe we should change this LOG to
Given interval value : {} is not a number and not match human readable
format, value will set to 0.
is it right? i will change it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
