Apache9 commented on code in PR #5509:
URL: https://github.com/apache/hbase/pull/5509#discussion_r1389560762
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##########
@@ -94,8 +94,9 @@ private void checkObsoleteConfigurations() {
}
}
- public MobFileCleanerChore() {
+ public MobFileCleanerChore(Admin admin) {
Review Comment:
OK, checked the code, they both only call the cleanupObsoleteMobFiles
method. I think we could introduce something like MobCleanupUtil, and put the
cleanupObsoleteMobFiles and archiveMobFiles in it, where we need to change them
to static methods, and then call them from the two classes, and also here, in
MobFileCleanerChore. In this way we do not need to maintain this constructor
then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
