bbeaudreault commented on code in PR #5534:
URL: https://github.com/apache/hbase/pull/5534#discussion_r1409830792


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java:
##########
@@ -53,6 +54,16 @@ public class ReopenTableRegionsProcedure
 
   private static final Logger LOG = 
LoggerFactory.getLogger(ReopenTableRegionsProcedure.class);
 
+  public static final String REOPEN_BATCH_BACKOFF_MILLIS_KEY =
+    "hbase.table.regions.reopen.batch.backoff.ms";
+  public static final long REOPEN_BATCH_BACKOFF_MILLIS_DEFAULT = 0L;
+  public static final String REOPEN_BATCH_SIZE_MAX_KEY =
+    "hbase.table.regions.reopen.batch.size.max";
+  public static final int REOPEN_BATCH_SIZE_MAX_DEFAULT = Integer.MAX_VALUE;

Review Comment:
   nitpick: we might want to have these names be 
`hbase.reopen.table.regions.progressive.batch.size.max` and `backoff.ms`.  It's 
more of a progressive reopen system now, and i reordered the 
table.regions.reopen to align more with the procedure name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to