[ https://issues.apache.org/jira/browse/HBASE-28212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791469#comment-17791469 ]
Hudson commented on HBASE-28212: -------------------------------- Results for branch branch-2 [build #933 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/933/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/933/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/933/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/933/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/933/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Do not need to maintain rollback step when root procedure does not support > rollback > ----------------------------------------------------------------------------------- > > Key: HBASE-28212 > URL: https://issues.apache.org/jira/browse/HBASE-28212 > Project: HBase > Issue Type: Improvement > Components: master, proc-v2 > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Major > Fix For: 2.6.0, 2.4.18, 3.0.0-beta-1, 2.5.7 > > > In HBASE-28210, we need to synchronized on RootProcedureState when updating > procedure store, which will decrease the performance a lot when there are > lots of sub procedures for a procedure, such as SCP, so it will impact MTTR. > But actually, SCP does not support rollback, so I do not think we need to > maintain this information. If so, I think we do not need the synchronization > added in HBASE-28210, at least for SCP then. This could get the performance > back. -- This message was sent by Atlassian Jira (v8.20.10#820010)