[ https://issues.apache.org/jira/browse/HBASE-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416842#comment-13416842 ]
Hadoop QA commented on HBASE-6220: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12536928/ServerMetrics_HBASE_6220_Flush_Metrics.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2396//console This message is automatically generated. > PersistentMetricsTimeVaryingRate gets used for non-time-based metrics > --------------------------------------------------------------------- > > Key: HBASE-6220 > URL: https://issues.apache.org/jira/browse/HBASE-6220 > Project: HBase > Issue Type: Bug > Components: metrics > Affects Versions: 0.96.0 > Reporter: David S. Wang > Assignee: Paul Cavallaro > Priority: Minor > Labels: noob > Attachments: ServerMetrics_HBASE_6220.patch, > ServerMetrics_HBASE_6220_Flush_Metrics.patch > > > PersistentMetricsTimeVaryingRate gets used for metrics that are not > time-based, leading to confusing names such as "avg_time" for compaction > size, etc. You hav to read the code in order to understand that this is > actually referring to bytes, not seconds. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira