stoty commented on PR #5571: URL: https://github.com/apache/hbase/pull/5571#issuecomment-1849348426
I have added caching to JDK detection, so it doesn't perform the expensive calls twice. We could save and re-use the result in a variable directly, but I'm not sure if that would be more readable. We could make some JDK version handling function, but I think that with the parameters, debug messages, and dynamically eveluated functions for lambdas, it would hurt readba However, the problematic JDK17 dependency is only present in tests, so don't have to bother with it in the runtime scripts. I'm going to remove the JDK17 specific code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
